johnjcasey commented on code in PR #29390:
URL: https://github.com/apache/beam/pull/29390#discussion_r1399662826
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##########
@@ -262,8 +262,7 @@ private static TableFieldSchema
fieldDescriptorFromAvroField(Schema.Field field)
elementType.getType() != Schema.Type.UNION,
"Multiple non-null union types are not supported.");
TableFieldSchema unionFieldSchema =
- fieldDescriptorFromAvroField(
- new Schema.Field(field.name(), elementType, field.doc(),
field.defaultVal()));
+ fieldDescriptorFromAvroField(new Schema.Field(field.name(),
elementType, field.doc()));
Review Comment:
In this case, the code here just is about trying to determine schema
information. the default value doesn't appear to be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
