Abacn commented on PR #28590: URL: https://github.com/apache/beam/pull/28590#issuecomment-1828482369
> This PR has introduced a race between the setting of `serializationCache` and the write. We are seeing flaky tests in scio (tracking issue [spotify/scio#5099](https://github.com/spotify/scio/issues/5099)) > > I am not sure why the cache should be cleared on `get` or `readExternal`, but if that is necessary `serializationCache` accesses should be synchronized It sounds the concern in https://github.com/apache/beam/pull/28590#discussion_r1337550437 was valid. @kellen do you suggest revert this change or there is a viable forward fix ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
