kellen commented on PR #28590: URL: https://github.com/apache/beam/pull/28590#issuecomment-1828503916
Ah apologies, I did not read all the comments here. In scio we have a bunch of tests running in parallel which previously revealed some unsafe (shared) usages of other structures inside beam, so I presume this is the same kind of thing. It is not clear to me where this shared usage is taking place. I suspect that there are multiple `get` calls somewhere, potentially in parallel, that are invalidating the cache in the middle of the `writeExternal` call. IMO synchronizing on serializedCache would be a sufficient fix, since that would avoid errors during write, even if the class overall is not considered thread-safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
