m-trieu commented on code in PR #28835:
URL: https://github.com/apache/beam/pull/28835#discussion_r1408164484
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/StreamingEngineClientTest.java:
##########
@@ -196,8 +196,7 @@ public void testStreamsStartCorrectly() throws
InterruptedException {
String workerToken = "workerToken1";
String workerToken2 = "workerToken2";
- Thread streamingEngineClientThread =
- new Thread(streamingEngineClient::waitForFirstWorkerMetadata);
+ Thread streamingEngineClientThread = new
Thread(this::waitForFirstWorkerMetadata);
Review Comment:
removed
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/StreamingEngineClientTest.java:
##########
@@ -480,6 +366,10 @@ private StreamingEngineConnectionState
waitForWorkerMetadataToBeConsumed(
return connections.get();
}
+ private void waitForFirstWorkerMetadata() {
+ while
(!Preconditions.checkNotNull(streamingEngineClient).isWorkerMetadataReady()) {}
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
