robinyqiu commented on a change in pull request #12403:
URL: https://github.com/apache/beam/pull/12403#discussion_r470228614
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -520,8 +526,11 @@ public int getSize() {
private void translateKnownStepCounters(CounterUpdate stepCounterUpdate) {
CounterStructuredName structuredName =
stepCounterUpdate.getStructuredNameAndMetadata().getName();
- if
(THROTTLING_MSECS_METRIC_NAME.getNamespace().equals(structuredName.getOriginNamespace())
- &&
THROTTLING_MSECS_METRIC_NAME.getName().equals(structuredName.getName())) {
+ if
((THROTTLING_MSECS_METRIC_NAME.getNamespace().equals(structuredName.getOriginNamespace())
+ &&
THROTTLING_MSECS_METRIC_NAME.getName().equals(structuredName.getName()))
+ || (BIGQUERY_STREAMING_INSERT_THROTTLE_TIME_NAMESPACE.equals(
Review comment:
Yes. GCS and Datastore counters are only consumed by batch worker (the
`THROTTLING_MSECS_METRIC_NAME` counter here is a separate counter; I am not
sure what this is. Maybe all throttling metrics should go to this counter?
@ihji I saw you have a JIRA about it, not sure if this what you want to do).
Here in the streaming case, precision is on millisecond (whereas GCS and
DataStore only store seconds)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
