robinyqiu commented on a change in pull request #12403:
URL: https://github.com/apache/beam/pull/12403#discussion_r471830220
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchModeExecutionContext.java
##########
@@ -543,6 +547,16 @@ public Long extractThrottleTime() {
totalThrottleTime += httpClientApiThrottlingTime.getCumulative();
}
+ CounterCell bigqueryStreamingInsertThrottleTime =
+ container.tryGetCounter(
+ MetricName.named(
+ BIGQUERY_STREAMING_INSERT_THROTTLE_TIME_NAMESPACE,
+ BIGQUERY_STREAMING_INSERT_THROTTLE_TIME_NAME));
Review comment:
Hi @chamikaramj @ihji ! I have made the change such that BQ, GCS, and
Datastore all report throttled time in milliseconds at the beginning, and they
now share the common counter name for consistency. The millisecond to second
conversion is done only when later a throttled time in seconds is expected by
worker side code. PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
