igorbernstein2 commented on code in PR #29548:
URL: https://github.com/apache/beam/pull/29548#discussion_r1414616962
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1138,8 +1162,26 @@ public PCollection<BigtableWriteResult> expand(
bigtableConfig.validate();
bigtableWriteOptions.validate();
+ // Get experimental flag and set on BigtableWriteOptions
+ PipelineOptions pipelineOptions = input.getPipeline().getOptions();
+ String closeWaitTimeoutStr =
+ ExperimentalOptions.getExperimentValue(pipelineOptions,
BIGTABLE_WRITER_WAIT_TIMEOUT_MS);
+ Duration closeWaitTimeout = null;
+ if (closeWaitTimeoutStr != null) {
+ long closeWaitTimeoutMs = Long.parseLong(closeWaitTimeoutStr);
+ if (closeWaitTimeoutMs < 0) {
Review Comment:
nit. Precondition.checkState
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
