igorbernstein2 commented on code in PR #29548:
URL: https://github.com/apache/beam/pull/29548#discussion_r1416047923
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1237,14 +1281,7 @@ public void finishBundle(FinishBundleContext c) throws
Exception {
entry.getKey().maxTimestamp(),
entry.getKey());
}
- }
- @Teardown
- public void tearDown() throws Exception {
- if (bigtableWriter != null) {
- bigtableWriter.close();
- bigtableWriter = null;
- }
if (serviceEntry != null) {
Review Comment:
can you throw this in a finally block to make sure the ref count doesnt leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
