zechenj18 commented on code in PR #29590:
URL: https://github.com/apache/beam/pull/29590#discussion_r1416298669
##########
sdks/go/pkg/beam/core/runtime/options.go:
##########
@@ -65,16 +65,22 @@ type RawOptions struct {
// TODO(herohde) 3/12/2018: remove the extra options wrapper and the bogus
// fields current required by the Java runners.
+// AdditionalOptions contains options in addition to those listed in RawOptions
+type AdditionalOptions struct {
+ Experiments []string `json:"experiments"`
+}
+
// RawOptionsWrapper wraps RawOptions to the form expected by the
// harness. The extra layer is currently needed due to Dataflow
// expectations about this representation. Subject to change.
type RawOptionsWrapper struct {
- Options RawOptions `json:"beam:option:go_options:v1"`
- Runner string `json:"beam:option:runner:v1"`
- AppName string `json:"beam:option:app_name:v1"`
- Experiments []string `json:"beam:option:experiments:v1"`
- RetainDocker bool `json:"beam:option:retain_docker_containers:v1"`
- Parallelism int `json:"beam:option:parallelism:v1"`
+ Options RawOptions `json:"beam:option:go_options:v1"`
+ Runner string `json:"beam:option:runner:v1"`
+ AppName string `json:"beam:option:app_name:v1"`
+ Experiments []string `json:"beam:option:experiments:v1"`
+ RetainDocker bool
`json:"beam:option:retain_docker_containers:v1"`
+ Parallelism int `json:"beam:option:parallelism:v1"`
+ AdditionalOptions AdditionalOptions `json:"options"`
Review Comment:
Thanks for pointing it out. I've updated the code to populate experiments
inside beam:option:go_options:v1.
I also tried to put experiments inside beam:option:experiments:v1 but
unfortunately it's not allowed by java runners so I guess moving it to
beam:option:go_options:v1 seems to be the only option now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
