zechenj18 commented on code in PR #29590:
URL: https://github.com/apache/beam/pull/29590#discussion_r1418044698
##########
sdks/go/pkg/beam/core/runtime/harness/harness.go:
##########
@@ -49,6 +50,7 @@ const URNMonitoringInfoShortID =
"beam:protocol:monitoring_info_short_ids:v1"
type Options struct {
RunnerCapabilities []string // URNs for what runners are able to
understand over the FnAPI.
StatusEndpoint string // Endpoint for worker status reporting.
+ EnableDataSampling bool // Enable data sampling feature
Review Comment:
Done :)
##########
sdks/go/pkg/beam/core/runtime/exec/pcollection.go:
##########
@@ -96,6 +102,13 @@ func (p *PCollection) ProcessElement(ctx context.Context,
elm *FullValue, values
var w byteCounter
p.elementCoder.Encode(elm, &w)
p.addSize(int64(w.count))
+
+ if p.dataSampler != nil {
+ var buf bytes.Buffer
+ EncodeWindowedValueHeader(p.windowCoder, elm.Windows,
elm.Timestamp, elm.Pane, &buf)
+ p.elementCoder.Encode(elm, &buf)
Review Comment:
Done : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
