lukecwik commented on a change in pull request #12577:
URL: https://github.com/apache/beam/pull/12577#discussion_r470363987
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -1047,7 +1047,9 @@ public void setMaxReadTime(Long maxReadTime) {
// "beam_fn_api_use_deprecated_read" is not enabled.
if (!ExperimentalOptions.hasExperiment(input.getPipeline().getOptions(),
"beam_fn_api")
|| ExperimentalOptions.hasExperiment(
- input.getPipeline().getOptions(),
"beam_fn_api_use_deprecated_read")) {
+ input.getPipeline().getOptions(),
"beam_fn_api_use_deprecated_read")
+ || !ExperimentalOptions.hasExperiment(
+ input.getPipeline().getOptions(), "use_sdf_kafka_read")) {
Review comment:
You'll need to add this experiment to the impacted tests since some
tests expect an SDF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
