boyuanzz commented on a change in pull request #12577:
URL: https://github.com/apache/beam/pull/12577#discussion_r470379176
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -1047,7 +1047,9 @@ public void setMaxReadTime(Long maxReadTime) {
// "beam_fn_api_use_deprecated_read" is not enabled.
if (!ExperimentalOptions.hasExperiment(input.getPipeline().getOptions(),
"beam_fn_api")
|| ExperimentalOptions.hasExperiment(
- input.getPipeline().getOptions(),
"beam_fn_api_use_deprecated_read")) {
+ input.getPipeline().getOptions(),
"beam_fn_api_use_deprecated_read")
+ || !ExperimentalOptions.hasExperiment(
+ input.getPipeline().getOptions(), "use_sdf_kafka_read")) {
Review comment:
I couldn't find a way to pass experiments into ExpansionService:
https://github.com/apache/beam/blob/master/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java#L384-L393
so I just leave the test to verity non-sdf read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
