AnandInguva commented on code in PR #29564:
URL: https://github.com/apache/beam/pull/29564#discussion_r1421006250
##########
sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py:
##########
@@ -44,7 +46,9 @@
VertexAITextEmbeddings is None, 'Vertex AI Python SDK is not installed.')
class VertexAIEmbeddingsTest(unittest.TestCase):
def setUp(self) -> None:
- self.artifact_location = tempfile.mkdtemp()
+ self.artifact_location = tempfile.mkdtemp(prefix='_vertex_ai_test')
+ self.gcs_artifact_location = os.path.join(
+ 'gs://apache-beam-ml/testing/vertex_ai', uuid.uuid4().hex)
Review Comment:
Yes but right now, In GcsIO client of io/gcp, there is a bug which doesn't
delete dirs from a GCS bucket. Once that is solved, we can use it to delete
the directory.
Also, for now, we could use `gs://temp-storage-for-perf-tests` which have
TTL for blobs in that bucket but the naming of the bucket would be odd for
these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
