damccorm commented on code in PR #29564:
URL: https://github.com/apache/beam/pull/29564#discussion_r1422563177


##########
sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py:
##########
@@ -44,7 +46,9 @@
     VertexAITextEmbeddings is None, 'Vertex AI Python SDK is not installed.')
 class VertexAIEmbeddingsTest(unittest.TestCase):
   def setUp(self) -> None:
-    self.artifact_location = tempfile.mkdtemp()
+    self.artifact_location = tempfile.mkdtemp(prefix='_vertex_ai_test')
+    self.gcs_artifact_location = os.path.join(
+        'gs://apache-beam-ml/testing/vertex_ai', uuid.uuid4().hex)

Review Comment:
   I think this is fine for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to