chamikaramj commented on code in PR #29859:
URL: https://github.com/apache/beam/pull/29859#discussion_r1440914899
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/CoderTranslation.java:
##########
@@ -60,6 +62,9 @@ private static class DefaultTranslationContext implements
TranslationContext {}
// TODO: standardize such things
public static final String JAVA_SERIALIZED_CODER_URN =
"beam:coders:javasdk:0.1";
+ public static final List<String> KNOWN_EXTERNAL_CODERS =
Review Comment:
I think we want to differentiate the primary use-case this PR is handling
(consecutive external transforms) from actual unknown coders used in the Java
side. For Java unknown coders we should just keep the existing failure path.
Also, I think the set of coders we need to cover here is a small list (one/few
per SDK) since we are primarily trying to make sure that the pipeline doesn't
fail to expand when external SDKs end up using the default coder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
