robertwb commented on code in PR #29859:
URL: https://github.com/apache/beam/pull/29859#discussion_r1440936398
##########
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/CoderTranslation.java:
##########
@@ -60,6 +62,9 @@ private static class DefaultTranslationContext implements
TranslationContext {}
// TODO: standardize such things
public static final String JAVA_SERIALIZED_CODER_URN =
"beam:coders:javasdk:0.1";
+ public static final List<String> KNOWN_EXTERNAL_CODERS =
Review Comment:
I'm still not following this. What "actual unknown coders used in the Java
side" would we have that we want to preserve the existing failure paths for.
(And why?) If we're trying to make sure the pipeline doesn't fail when using
external SDKs it doesn't seem like the right general approach to hardcode a
subset of coders a that particular external SDK currently uses, even if this
list is slowly changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
