kennknowles commented on code in PR #29992:
URL: https://github.com/apache/beam/pull/29992#discussion_r1449526770


##########
.github/gh-actions-self-hosted-runners/arc/images/Dockerfile:
##########
@@ -41,6 +41,9 @@ RUN curl -OL 
https://cdn.azul.com/zulu/bin/zulu8.70.0.23-ca-jdk8.0.372-linux_x64
     tar -C /usr/local -xzf zulu8.70.0.23-ca-jdk8.0.372-linux_x64.tar.gz && \
     rm zulu8.70.0.23-ca-jdk8.0.372-linux_x64.tar.gz && \
     mv /usr/local/zulu8.70.0.23-ca-jdk8.0.372-linux_x64 /usr/local/java
+RUN curl -OL 
https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-linux_x64.tar.gz && \
+    tar -C /usr/local -xzf 
https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-linux_x64.tar.gz && \
+    rm zulu17.46.19-ca-jdk17.0.9-linux_x64.tar.gz

Review Comment:
   I'm not sure how this works, but this is a thing:
   
   ```
   % ./gradlew -q javaToolchains
   
    + Options
        | Auto-detection:     Enabled
        | Auto-download:      Enabled
   
    + Azul Zulu JDK 11.0.21+9-LTS
        | Location:           
/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home
        | Language Version:   11
        | Vendor:             Azul Zulu
        | Architecture:       x86_64
        | Is JDK:             true
        | Detected by:        MacOS java_home
   
    + Azul Zulu JDK 20.0.2+9
        | Location:           
/Library/Java/JavaVirtualMachines/zulu-20.jdk/Contents/Home
        | Language Version:   20
        | Vendor:             Azul Zulu
        | Architecture:       x86_64
        | Is JDK:             true
        | Detected by:        MacOS java_home
   
    + Azul Zulu JDK 21.0.1+12-LTS
        | Location:           
/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home
        | Language Version:   21
        | Vendor:             Azul Zulu
        | Architecture:       x86_64
        | Is JDK:             true
        | Detected by:        Current JVM
   
    + Oracle JDK 1.8.0_221-b11
        | Location:           
/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home
        | Language Version:   8
        | Vendor:             Oracle
        | Architecture:       x86_64
        | Is JDK:             true
        | Detected by:        MacOS java_home
   
    + Oracle JRE 1.8.0_221-b11
        | Location:           /Library/Internet 
Plug-Ins/JavaAppletPlugin.plugin/Contents/Home
        | Language Version:   8
        | Vendor:             Oracle
        | Architecture:       x86_64
        | Is JDK:             false
        | Detected by:        MacOS java_home
   ```
   
   Which makes me think it may be that we just select them directly. Or just 
set JAVA_HOME directly to wherever we unpack it, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to