Abacn commented on code in PR #29992: URL: https://github.com/apache/beam/pull/29992#discussion_r1456846008
########## .github/gh-actions-self-hosted-runners/arc/images/Dockerfile: ########## @@ -41,6 +41,9 @@ RUN curl -OL https://cdn.azul.com/zulu/bin/zulu8.70.0.23-ca-jdk8.0.372-linux_x64 tar -C /usr/local -xzf zulu8.70.0.23-ca-jdk8.0.372-linux_x64.tar.gz && \ rm zulu8.70.0.23-ca-jdk8.0.372-linux_x64.tar.gz && \ mv /usr/local/zulu8.70.0.23-ca-jdk8.0.372-linux_x64 /usr/local/java +RUN curl -OL https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-linux_x64.tar.gz && \ + tar -C /usr/local -xzf https://cdn.azul.com/zulu/bin/zulu17.46.19-ca-jdk17.0.9-linux_x64.tar.gz && \ + rm zulu17.46.19-ca-jdk17.0.9-linux_x64.tar.gz Review Comment: > I know setup-java will setup toolchains like this. I'd expect if Java was already on the path it wouldn't reinstall it (though I don't know for sure) and would just set up the toolchain. Currently the java environment is an optional parameter of the setup-environment-action action. If not provided, the action runs on this pre-installed java version, e.g. https://github.com/apache/beam/blob/79b9de283feda3c4efea7be4e90c2b7ef4ebfb40/.github/workflows/beam_PreCommit_Java.yml#L178. If provided, it will use the (back of the list) configured java version as the default java command, e.g.: https://github.com/apache/beam/blob/79b9de283feda3c4efea7be4e90c2b7ef4ebfb40/.github/workflows/beam_PreCommit_SQL_Java11.yml#L84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
