scwhittle commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1458591244
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1363,6 +1385,10 @@ private void commitLoop() {
// Adds the commit to the commitStream if it fits, returning true iff it is
consumed.
private boolean addCommitToStream(Commit commit, CommitWorkStream
commitStream) {
Preconditions.checkNotNull(commit);
+ // Drop commits for failed work. Such commits will be dropped by Windmill
anyway.
+ if (commit.work().isFailed()) {
+ return true;
Review Comment:
That ends up as a counter in dataflow backend. I was just thinking a local
variable that is just rendered on the status page. But also unnecessary if you
want to just drop that request to make sure we make the cut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
