acrites commented on code in PR #29963:
URL: https://github.com/apache/beam/pull/29963#discussion_r1459866899
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1363,6 +1385,10 @@ private void commitLoop() {
// Adds the commit to the commitStream if it fits, returning true iff it is
consumed.
private boolean addCommitToStream(Commit commit, CommitWorkStream
commitStream) {
Preconditions.checkNotNull(commit);
+ // Drop commits for failed work. Such commits will be dropped by Windmill
anyway.
+ if (commit.work().isFailed()) {
+ return true;
Review Comment:
It seems like we'd want some kind of sliding window counter, e.g. how many
failed in the last 5 minutes. Otherwise we just get some arbitrarily large
number after the pipeline has been running for awhile. Let's wait on adding
some visibility for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
