JayajP commented on code in PR #30089:
URL: https://github.com/apache/beam/pull/30089#discussion_r1465356303
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingStepMetricsContainer.java:
##########
@@ -68,6 +74,14 @@ public class StreamingStepMetricsContainer implements
MetricsContainer {
private MetricsMap<KV<MetricName, HistogramData.BucketType>, HistogramCell>
perWorkerHistograms =
new MetricsMap<>(HistogramCell::new);
+ private Map<MetricName, Instant> perWorkerCountersByFirstStaleTime = new
ConcurrentHashMap<>();
+
+ // PerWorkerCounters that have been longer than this value will be removed
from the underlying
+ // metrics map.
+ private Duration maximumPerWorkerCounterStaleness = Duration.ofMinutes(5);
+
+ private Clock clock = Clock.systemUTC();
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
