Abacn commented on code in PR #30089:
URL: https://github.com/apache/beam/pull/30089#discussion_r1465624636
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingStepMetricsContainer.java:
##########
@@ -81,6 +98,28 @@ protected StreamingStepMetricsContainer
createContainer(String stepName) {
};
}
+ // Testing constructor.
Review Comment:
What does "Testing constructor" mean? I understand it as having some mock
objects so one can test. Probably (Construct a ... that supports mock Clock,
etc. For testing purposes only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
