Polber commented on code in PR #30024:
URL: https://github.com/apache/beam/pull/30024#discussion_r1470203741
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcReadSchemaTransformProvider.java:
##########
@@ -164,12 +194,17 @@ public abstract static class
JdbcReadSchemaTransformConfiguration implements Ser
public abstract String getDriverJars();
public void validate() throws IllegalArgumentException {
- if (Strings.isNullOrEmpty(getDriverClassName())) {
- throw new IllegalArgumentException("JDBC Driver class name cannot be
blank.");
+ if (Strings.isNullOrEmpty(getDriverClassName()) &&
Strings.isNullOrEmpty(getJdbcType())) {
Review Comment:
Hmm that's a good point. It is redundant to specify both - specifying
`jdbcType` that conflicts with `driverClassName` won't affect the code path
which will uses the `driverClassName` parameter and ignores the `jdbcType`.
This just might be misleading behavior, but I can remove the error for now
since it isn't technically an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
