robertwb commented on code in PR #30024:
URL: https://github.com/apache/beam/pull/30024#discussion_r1473621804
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcUtil.java:
##########
@@ -75,6 +77,23 @@ class JdbcUtil {
private static final Logger LOG = LoggerFactory.getLogger(JdbcUtil.class);
+ static final Map<String, String> JDBC_DRIVER_MAP =
+ new HashMap<>(
+ ImmutableMap.of(
+ "mysql",
+ "com.mysql.cj.jdbc.Driver",
+ "postgres",
+ "org.postgresql.Driver",
+ "oracle",
+ "oracle.jdbc.driver.OracleDriver",
+ "mssql",
+ "com.microsoft.sqlserver.jdbc.SQLServerDriver"));
+
+ @VisibleForTesting
Review Comment:
Oh, derby is an actual "fake/test" jdbc endpoint. I had totally missed this.
Yes, this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
