chamikaramj commented on code in PR #29924:
URL: https://github.com/apache/beam/pull/29924#discussion_r1488624205
##########
sdks/java/core/build.gradle:
##########
@@ -24,6 +24,19 @@ applyJavaNature(
'FileIO': 'https://github.com/typetools/checker-framework/issues/6388',
'MergingActiveWindowSetTest':
'https://github.com/typetools/checker-framework/issues/3776',
'WindowFnTestUtils':
'https://github.com/typetools/checker-framework/issues/3776',
+ 'WindowIntoTranslation':
'https://github.com/typetools/checker-framework/issues/3791',
Review Comment:
https://github.com/typetools/checker-framework/issues/3791 has been fixed.
Should we reference a different bug here ?
##########
sdks/java/core/build.gradle:
##########
@@ -77,13 +90,16 @@ dependencies {
shadow project(path: ":model:pipeline", configuration: "shadow")
shadow project(path: ":model:fn-execution", configuration: "shadow")
shadow project(path: ":model:job-management", configuration: "shadow")
+ shadow project(path: ":model:fn-execution", configuration: "shadow")
+ shadow project(path: ":sdks:java:transform-service:launcher") // not
"shadow" configuration, which is an uberjar
Review Comment:
Why do we need the "shadow" configuration for other projects referenced
above ?
Note that after
https://github.com/apache/beam/pull/30190/files#diff-c85538d3151bb7ac1847f9b888558c84a82705624f6fc453648aba1fa135c6d8
this is not an uber jar anymore.
##########
runners/direct-java/build.gradle:
##########
@@ -22,11 +22,11 @@ plugins { id 'org.apache.beam.module' }
// Shade away runner execution utilities till because this causes
ServiceLoader conflicts with
// TransformPayloadTranslatorRegistrar amongst other runners. This only
happens in the DirectRunner
// because it is likely to appear on the classpath of another runner.
-def dependOnProjects = [":runners:core-construction-java",
+def dependOnProjects = [
":runners:core-java",
":runners:local-java",
":runners:java-fn-execution",
- ":sdks:java:extensions:avro"
Review Comment:
Avro dependency is not needed anymore ?
##########
sdks/java/extensions/python/build.gradle:
##########
@@ -21,19 +21,16 @@ applyJavaNature( automaticModuleName:
'org.apache.beam.sdk.extensions.python')
description = "Apache Beam :: SDKs :: Java :: Extensions :: Python"
-evaluationDependsOn(":runners:core-construction-java")
-
dependencies {
implementation library.java.vendored_guava_32_1_2_jre
implementation library.java.vendored_grpc_1_60_1
implementation library.java.slf4j_api
implementation project(path: ":model:pipeline", configuration: "shadow")
- implementation project(path: ":runners:core-construction-java")
implementation project(path: ":sdks:java:core", configuration: "shadow")
- implementation project(path: ":sdks:java:transform-service:launcher")
+ implementation project(path: ":sdks:java:transform-service:launcher") //
not "shadow" configuration, which is an uberjar
Review Comment:
Ditto regarding the inconsistency when depending with other projects vs this
one.
##########
runners/direct-java/build.gradle:
##########
@@ -67,7 +66,6 @@ dependencies {
dependOnProjects.each {
implementation project(it)
}
- shadow project(path: ":sdks:java:core", configuration: "shadow")
Review Comment:
Ditto. Why did `direct-java` needed to depend on "core" before ?
##########
runners/core-construction-java/build.gradle:
##########
@@ -1,77 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * License); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-plugins { id 'org.apache.beam.module' }
Review Comment:
Yey :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
