kennknowles commented on code in PR #29924:
URL: https://github.com/apache/beam/pull/29924#discussion_r1488786974
##########
sdks/java/core/build.gradle:
##########
@@ -77,13 +90,16 @@ dependencies {
shadow project(path: ":model:pipeline", configuration: "shadow")
shadow project(path: ":model:fn-execution", configuration: "shadow")
shadow project(path: ":model:job-management", configuration: "shadow")
+ shadow project(path: ":model:fn-execution", configuration: "shadow")
+ shadow project(path: ":sdks:java:transform-service:launcher") // not
"shadow" configuration, which is an uberjar
Review Comment:
Done. There is no shadow configuration for the launcher. But for the other
ones, the non-shadow configuration is an uber jar (or at least it was). I think
the solution will be to start at the leaves and remove extraneous use of shadow
plugin. A big project and not as urgent I think.
##########
sdks/java/core/build.gradle:
##########
@@ -24,6 +24,19 @@ applyJavaNature(
'FileIO': 'https://github.com/typetools/checker-framework/issues/6388',
'MergingActiveWindowSetTest':
'https://github.com/typetools/checker-framework/issues/3776',
'WindowFnTestUtils':
'https://github.com/typetools/checker-framework/issues/3776',
+ 'WindowIntoTranslation':
'https://github.com/typetools/checker-framework/issues/3791',
Review Comment:
Done. I had to add suppression to each file but they don't crash
checkerframework.
##########
sdks/java/extensions/python/build.gradle:
##########
@@ -21,19 +21,16 @@ applyJavaNature( automaticModuleName:
'org.apache.beam.sdk.extensions.python')
description = "Apache Beam :: SDKs :: Java :: Extensions :: Python"
-evaluationDependsOn(":runners:core-construction-java")
-
dependencies {
implementation library.java.vendored_guava_32_1_2_jre
implementation library.java.vendored_grpc_1_60_1
implementation library.java.slf4j_api
implementation project(path: ":model:pipeline", configuration: "shadow")
- implementation project(path: ":runners:core-construction-java")
implementation project(path: ":sdks:java:core", configuration: "shadow")
- implementation project(path: ":sdks:java:transform-service:launcher")
+ implementation project(path: ":sdks:java:transform-service:launcher") //
not "shadow" configuration, which is an uberjar
Review Comment:
Done. It turns out launcher doesn't have a shadow configuration anyhow. This
is turned on/off by whether the shadow plugin is active. Ideally we stop using
it, because vendoring is the only shading we need, really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
