tvalentyn commented on code in PR #30307:
URL: https://github.com/apache/beam/pull/30307#discussion_r1491764820
##########
sdks/python/apache_beam/io/requestresponse.py:
##########
@@ -37,10 +47,33 @@
RequestT = TypeVar('RequestT')
ResponseT = TypeVar('ResponseT')
-DEFAULT_TIMEOUT_SECS = 30 # seconds
+# DEFAULT_TIMEOUT_SECS represents the time interval for completing the request
+# with external source.
+DEFAULT_TIMEOUT_SECS = 30
+
+# DEFAULT_TIME_TO_LIVE_SECS represents the total time to live for cache record.
+DEFAULT_TIME_TO_LIVE_SECS = 24 * 60 * 60
_LOGGER = logging.getLogger(__name__)
+__all__ = [
+ 'RequestResponseIO',
+ 'ExponentialBackOffRepeater',
+ 'DefaultThrottler',
+ 'NoOpsRepeater',
+ 'RedisCache',
+ 'ReadFromRedis',
Review Comment:
What is user-facing API and what are internal classes here?
Looks like RedisCache is user facing, so it should be here. What about other
classes? e.g.
If the transform `ReadFromRedis` is internal, it should be removed from
`__all__` and named as `_ReadFromRedis`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
