riteshghorse commented on code in PR #30307:
URL: https://github.com/apache/beam/pull/30307#discussion_r1491804281
##########
sdks/python/apache_beam/io/requestresponse.py:
##########
@@ -37,10 +47,33 @@
RequestT = TypeVar('RequestT')
ResponseT = TypeVar('ResponseT')
-DEFAULT_TIMEOUT_SECS = 30 # seconds
+# DEFAULT_TIMEOUT_SECS represents the time interval for completing the request
+# with external source.
+DEFAULT_TIMEOUT_SECS = 30
+
+# DEFAULT_TIME_TO_LIVE_SECS represents the total time to live for cache record.
+DEFAULT_TIME_TO_LIVE_SECS = 24 * 60 * 60
_LOGGER = logging.getLogger(__name__)
+__all__ = [
+ 'RequestResponseIO',
+ 'ExponentialBackOffRepeater',
+ 'DefaultThrottler',
+ 'NoOpsRepeater',
+ 'RedisCache',
+ 'ReadFromRedis',
+ 'WriteToRedis',
+ 'RedisCaller',
+ 'DEFAULT_TIMEOUT_SECS',
Review Comment:
Yes. The reason behind adding them here was I referenced these in doc
comments with `:class:` and pydoc used to complain about it. It usually looks
good in the doc to reference like this. But I guess I can use tilde(`~`) as it
is defying the purpose of __all__ here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
