apilloud commented on a change in pull request #12596:
URL: https://github.com/apache/beam/pull/12596#discussion_r472331284
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -128,7 +129,8 @@ public String getDefaultTimezone() {
return plannerImpl.getDefaultTimezone();
}
- public void setDefaultTimezone(String timezone) {
+ public void
setDefaultTimezone(@UnderInitialization(ZetaSQLQueryPlanner.class)
ZetaSQLQueryPlanner this,
Review comment:
This can be called at any time, not just initialization. I think it
would be possible to delete this function, initialize the timezone in the
constructor, and require a new ZetaSQLQueryPlanner to be constructed to change
the default.
cc: @robinyqiu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
