jayendra13 commented on a change in pull request #12596:
URL: https://github.com/apache/beam/pull/12596#discussion_r478296968
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java
##########
@@ -51,6 +53,7 @@ public RelNode convert(ResolvedTVFScan zetaNode,
List<RelNode> inputs) {
zetaNode.getArgumentList().get(0).getScan() != null
?
zetaNode.getArgumentList().get(0).getScan().getColumnList()
: Collections.emptyList());
+ @SuppressWarnings("argument.type.incompatible") // create function accepts
null for elementType
Review comment:
is it ok to suppress this warning or is it fixable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
