m-trieu commented on PR #30265: URL: https://github.com/apache/beam/pull/30265#issuecomment-1960200318
> Looks like this assert failed in test: > > https://github.com/apache/beam/blob/0bce6d7a834c521a3d3043ab9377fcd2f2e16f0a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java#L3355 > > Could be flaky if doesn't wait enough to get commit or it could be an indication that the heartbeat response plumbing isn't working. @scwhittle ran locally and it passed. looks we depend on sleep() in the test, and i wonder if that leads to flakiness in the GitHub actions environment? ``` Map<Long, Windmill.WorkItemCommitRequest> commits = server.waitForAndGetCommitsWithTimeout(2, Duration.standardSeconds((5))); assertEquals(1, commits.size()); ``` also kind of strange that we are waiting for 2 commits but are asserting that there is only 1 commit. But looks like this is a flaky test failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
