scwhittle commented on code in PR #30265:
URL: https://github.com/apache/beam/pull/30265#discussion_r1500946427
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -462,42 +446,89 @@ public void run() {
LOG.debug("maxWorkItemCommitBytes: {}", maxWorkItemCommitBytes);
}
- private static WindmillServerStub createWindmillServerStub(
+ public static StreamingDataflowWorker
fromOptions(StreamingDataflowWorkerOptions options) {
+ ConcurrentMap<String, ComputationState> computationMap = new
ConcurrentHashMap<>();
+ long clientId = clientIdGenerator.nextLong();
+ return new StreamingDataflowWorker(
+ createWindmillServerStub(
+ options,
+ clientId,
+ new WorkHeartbeatResponseProcessor(
Review Comment:
I don't see where this is setup if the forTesting method is used.
Are you sure this isn't the cause of the test failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
