Abacn commented on code in PR #30367:
URL: https://github.com/apache/beam/pull/30367#discussion_r1502950295
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoByteBuddyUtils.java:
##########
@@ -538,7 +538,7 @@ static <ProtoT> FieldValueGetter<ProtoT, OneOfType.Value>
createOneOfGetter(
return builder
.visit(new
AsmVisitorWrapper.ForDeclaredMethods().writerFlags(ClassWriter.COMPUTE_FRAMES))
.make()
- .load(ReflectHelpers.findClassLoader(),
ClassLoadingStrategy.Default.INJECTION)
+ .load(ReflectHelpers.findClassLoader(),
getClassLoadingStrategy(protoClass))
Review Comment:
while the change of all other files follow the same pattern, the use case
here looks slightly different. Would you mind providing some hint to the
changes in ProroByteBuddyUtil ?
Or if there is anything not sure, we can leave this file untouched. I just
recall the last time of this effort (#23210) broke some test and had some back
and forth. I was wondering if any remaining usage Default.INJECTION not removed
in #25578 was due to that it is nontrivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
