scwhittle commented on code in PR #30367:
URL: https://github.com/apache/beam/pull/30367#discussion_r1503192352
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoByteBuddyUtils.java:
##########
@@ -538,7 +538,7 @@ static <ProtoT> FieldValueGetter<ProtoT, OneOfType.Value>
createOneOfGetter(
return builder
.visit(new
AsmVisitorWrapper.ForDeclaredMethods().writerFlags(ClassWriter.COMPUTE_FRAMES))
.make()
- .load(ReflectHelpers.findClassLoader(),
ClassLoadingStrategy.Default.INJECTION)
+ .load(ReflectHelpers.findClassLoader(),
getClassLoadingStrategy(protoClass))
Review Comment:
the class used was the one used for package injection in the helper method.
But since I'm not sure how to best test this and it wasn't directly causing
issues for me I'm removing from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
