kennknowles commented on code in PR #30488:
URL: https://github.com/apache/beam/pull/30488#discussion_r1514704298
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/adapter/BeamAdapterUtils.java:
##########
@@ -76,7 +76,8 @@ Map<String, DataSetOrStreamT> applyBeamPTransformInternal(
new FlinkInput<>(
key,
BeamAdapterCoderUtils.typeInformationToCoder(
-
getTypeInformation.apply(Preconditions.checkNotNull(flinkInput)),
coderRegistry)))));
+
getTypeInformation.apply(Preconditions.checkNotNull(flinkInput)),
Review Comment:
lol I think I got the direction of variance wrong in the `Function<X extends
Foo, ...>`. It is a pain and easy to get wrong, which is why we have type
checkers of course :-)
My other take is that if the type checker cannot understand it, a person
coming to the code with no context also probably cannot understand it easily.
I'm sure _you_ understand it well enough, especially at the time of authoring
the code :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
