kennknowles commented on code in PR #30488:
URL: https://github.com/apache/beam/pull/30488#discussion_r1518335111
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/adapter/FlinkInput.java:
##########
@@ -71,7 +71,7 @@ public String getUrn() {
}
@Override
- @SuppressWarnings("nullness") //
TODO(https://github.com/apache/beam/issues/20497)
+ @SuppressWarnings("nullness") //
TODO(https://github.com/apache/beam/issues/20497)
Review Comment:
Yea ha I cloned it and checked. Of course, the return type is also
mismatched and it is an example of suppression overshadowing. But wow yea I
fully understand taking a pass on fixing that wild generics / variance issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
