ahmedabu98 commented on code in PR #30560:
URL: https://github.com/apache/beam/pull/30560#discussion_r1519945751
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/SchemaTransformProvider.java:
##########
@@ -58,10 +59,14 @@ default String description() {
SchemaTransform from(Row configuration);
/** Returns the input collection names of this transform. */
- List<String> inputCollectionNames();
+ default List<String> inputCollectionNames() {
Review Comment:
In reality, developers make their providers by extending
TypedSchemaTransformProvider, which implements SchemaTransformProvider. I guess
intellij might grey it out because they're not directly used from
SchemaTransformProvider
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/TypedSchemaTransformProvider.java:
##########
@@ -39,7 +42,16 @@
@Internal
public abstract class TypedSchemaTransformProvider<ConfigT> implements
SchemaTransformProvider {
- protected abstract Class<ConfigT> configurationClass();
+ @SuppressWarnings("unchecked")
+ protected Class<ConfigT> configurationClass() {
+ Optional<ParameterizedType> parameterizedType =
Review Comment:
Thanks, applied the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
