kennknowles commented on code in PR #30560:
URL: https://github.com/apache/beam/pull/30560#discussion_r1520303018
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/SchemaTransformProvider.java:
##########
@@ -58,10 +59,14 @@ default String description() {
SchemaTransform from(Row configuration);
/** Returns the input collection names of this transform. */
- List<String> inputCollectionNames();
+ default List<String> inputCollectionNames() {
Review Comment:
So if they override these methods but we never call them, does it matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
