kennknowles commented on PR #30604: URL: https://github.com/apache/beam/pull/30604#issuecomment-1989673146
Nope, it looks like there are just tests that set `use_runner_v2` but then check that things happen during the v1 translation. Specifically the runner v1 translation was used to do client-side validation of what features were supported on v2. That definitely needs to be service-side so that service can evolve support without an SDK release. So actually this PR is a major upgrade in that sense, but we need to check that the service-side translation has adequate validation. Might commit a smaller version like your PR first, considering all this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
