kennknowles commented on PR #30604: URL: https://github.com/apache/beam/pull/30604#issuecomment-1989677693
R: @scwhittle for the removed tests. They were testing things that honestly wouldn't work right, but curious where are your thoughts on this, as it pertains to the status of the service's level of care in v2 codepaths: - level of validation for SetState and MapState support which should happen in the backend - don't really understand what is the deal with the GroupIntoBatches stuff - whether there is something in the service that somehow was trying to depend on the pubsub sink v1 translation even in v2? To be clear, all these tests are testing whether the v1 translation has some behavior when the actual pipeline is running on v2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
