m-trieu commented on PR #30312:
URL: https://github.com/apache/beam/pull/30312#issuecomment-1992363815

   added drain (fail work and clear queues) when we close the SEWorkCommitter
   
   will need this for direct path. in non direct path mode we would never call 
stop (except when we call stop on the entire harness in 
StreamingDataflowWorker) so it will not affect that code path. @scwhittle 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to