m-trieu commented on code in PR #30312:
URL: https://github.com/apache/beam/pull/30312#discussion_r1522084554
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/WeightedBoundedQueue.java:
##########
@@ -98,4 +99,12 @@ public int queuedElementsWeight() {
public int size() {
return queue.size();
}
+
+ public Stream<V> stream() {
+ return queue.stream();
+ }
+
+ public void clear() {
+ queue.clear();
Review Comment:
done
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/commits/StreamingEngineWorkCommitter.java:
##########
@@ -113,6 +113,17 @@ public void stop() {
}
commitSenders.shutdownNow();
}
+ drainCommitQueue();
+ }
+
+ private void drainCommitQueue() {
+ commitQueue.stream().forEach(this::failCommit);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
