Abacn commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526621904
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java:
##########
@@ -262,8 +262,7 @@ private static TableFieldSchema
fieldDescriptorFromAvroField(Schema.Field field)
elementType.getType() != Schema.Type.UNION,
"Multiple non-null union types are not supported.");
TableFieldSchema unionFieldSchema =
- fieldDescriptorFromAvroField(
- new Schema.Field(field.name(), elementType, field.doc(),
field.defaultVal()));
Review Comment:
why defaultVal dropped here?
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -630,7 +630,7 @@ public static SimpleFunction<Row, byte[]>
getRowToAvroBytesFunction(Schema beamS
}
private static class RowToAvroBytesFn extends SimpleFunction<Row, byte[]> {
- private final transient org.apache.avro.Schema avroSchema;
+ private final org.apache.avro.Schema avroSchema;
Review Comment:
also this change
##########
sdks/java/extensions/avro/build.gradle:
##########
@@ -72,6 +72,7 @@ dependencies {
}
testImplementation library.java.avro_tests
testImplementation library.java.junit
+ testImplementation "org.tukaani:xz:1.9" // marked as optional in avro
Review Comment:
would you mind explaining a little bit how this change needed
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -664,8 +664,8 @@ class BeamModulePlugin implements Plugin<Project> {
antlr_runtime :
"org.antlr:antlr4-runtime:4.7",
args4j : "args4j:args4j:2.33",
auto_value_annotations :
"com.google.auto.value:auto-value-annotations:$autovalue_version",
- avro :
"org.apache.avro:avro:1.8.2",
- avro_tests :
"org.apache.avro:avro:1.8.2:tests",
+ avro :
"org.apache.avro:avro:1.11.3",
+ avro_tests :
"org.apache.avro:avro:1.11.3:tests",
Review Comment:
I remember there was issue upgrading avro version and that was why it
sticked to 1.8.2 for a long time. Might be good to ask in devlist about this
proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
