tilgalas commented on code in PR #30638:
URL: https://github.com/apache/beam/pull/30638#discussion_r1526708241
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -630,7 +630,7 @@ public static SimpleFunction<Row, byte[]>
getRowToAvroBytesFunction(Schema beamS
}
private static class RowToAvroBytesFn extends SimpleFunction<Row, byte[]> {
- private final transient org.apache.avro.Schema avroSchema;
+ private final org.apache.avro.Schema avroSchema;
Review Comment:
if the field is left transient there's a spotbugs warning that it's not
being properly restored on deserialization - from what I see the Schema class
became Serializable in the updated version of the avro, so we should be able to
just serialize it and there's no need to mark it as transient anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
