robertwb commented on code in PR #30771:
URL: https://github.com/apache/beam/pull/30771#discussion_r1554181348
##########
sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py:
##########
@@ -78,178 +76,193 @@ def normalize_kv(k, v):
# For documentation.
NamedTuple = beam.Row
+
def check_groupby_expr_result(grouped):
- assert_that(
- grouped | beam.MapTuple(normalize_kv),
- equal_to([
- #[START groupby_expr_result]
- ('s', ['strawberry']),
- ('r', ['raspberry']),
- ('b', ['banana', 'blackberry', 'blueberry']),
- #[END groupby_expr_result]
- ]))
+ pass # TODO: Uncomment asserts
Review Comment:
Actually, since they're structured this way (sorry, I thought the asserts
were inline, these tests are structured a bit oddly with the code and asserts
is a separate file and a third line that links them), maybe just return here to
reduce churn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
