hjtran commented on code in PR #30771:
URL: https://github.com/apache/beam/pull/30771#discussion_r1554213775
##########
sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py:
##########
@@ -78,178 +76,193 @@ def normalize_kv(k, v):
# For documentation.
NamedTuple = beam.Row
+
def check_groupby_expr_result(grouped):
- assert_that(
- grouped | beam.MapTuple(normalize_kv),
- equal_to([
- #[START groupby_expr_result]
- ('s', ['strawberry']),
- ('r', ['raspberry']),
- ('b', ['banana', 'blackberry', 'blueberry']),
- #[END groupby_expr_result]
- ]))
+ pass # TODO: Uncomment asserts
Review Comment:
Ha, I initially put in early returns, but didn't want to fight possible
flake8 issues about unreachable code since my IDE was giving me a hard time
about it. I realize now flake8 doesn't complain about unreachable code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
