Polber commented on PR #30734:
URL: https://github.com/apache/beam/pull/30734#issuecomment-2040575468

   > @Polber Do I need to take any action or do I just wait for #30681 and 
#30864 to be merged?
   
   #30864 should fix the issue once it is merged. I was also wrong with my 
initial claim. Join will not be broken, it just cannot be followed by 
`LogForTesting` or 'Flatten` in a pipeline.
   
   > Also, I noticed that the `CROSS JOIN` operation is not working, even in 
the simple case of `SELECT * FROM A CROSS JOIN B`. The error I see when using 
`CROSS JOIN` is `java.lang.UnsupportedOperationException: CROSS JOIN, JOIN ON 
FALSE is not supported!`, suggesting that the SQL engine does not support the 
syntax.
   > 
   > Could this be related to the issues above? Or is `CROSS JOIN` truly not 
supported?
   
   Yeah looks like Beam SQL does not support cross joins. I think it is fine to 
not include in v1, and we can always implement custom CoGroupByKey logic to 
simulate a cross join.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to