Polber commented on code in PR #30734: URL: https://github.com/apache/beam/pull/30734#discussion_r1561492612
########## sdks/python/apache_beam/yaml/yaml_join_test.py: ########## @@ -0,0 +1,210 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import logging +import unittest + +import apache_beam as beam +from apache_beam.testing.util import assert_that +from apache_beam.testing.util import equal_to +from apache_beam.yaml.yaml_transform import YamlTransform + + +class ToRow(beam.PTransform): + def expand(self, pcoll): + return pcoll | beam.Map(lambda row: beam.Row(**row._asdict())) + + +FRUITS = [ + beam.Row(id=1, name='raspberry'), + beam.Row(id=2, name='blackberry'), +] + +QUANTITIES = [ + beam.Row(name='raspberry', quantity=1), + beam.Row(name='blackberry', quantity=2), + beam.Row(name='blueberry', quantity=3), +] + +CATEGORIES = [ + beam.Row(name='raspberry', category='juicy'), + beam.Row(name='blackberry', category='dry'), + beam.Row(name='blueberry', category='dry'), + beam.Row(name='blueberry', category='juicy'), +] + + +class YamlJoinTest(unittest.TestCase): Review Comment: @robertwb Have you verified that the integration_tests get run? I thought it ran pytest which would skip that file if it ends in 's', right? When I run pytest locally at least it doesn't run those -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
