Polber opened a new pull request, #30895:
URL: https://github.com/apache/beam/pull/30895
There are cases where `MapToFields` does not work for sql expressions where
a field in the incoming schema is a reserved keyword.
For example, with an input schema of
`{foo: int, timestamp: str}`
The following would fail:
```
- type: MapToFields
config:
language: sql
append: true
fields:
newField: foo
```
as the generated query is
`SELECT (timestamp) AS timestamp, (foo) AS foo, (foo) AS newField FROM
PCOLLECTION.`
where `(timestamp) AS timestamp` was generated due to `append: true` being
set.
---
This PR provides a fix by auto-escaping aliases that are generated by the
framework such as the example above, or when naming a field, i.e.
```
- type: MapToFields
name: Transform
config:
language: sql
fields:
timestamp: foo
```
Note: The expression itself will not be auto-backticked, so the following is
still expected to fail:
```
- type: MapToFields
config:
language: sql
fields:
foo: timestamp
```
a user would be expected to write valid SQL, i.e.
```
- type: MapToFields
config:
language: sql
fields:
foo: "`timestamp`"
```
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
