liferoad commented on code in PR #30895:
URL: https://github.com/apache/beam/pull/30895#discussion_r1556512365
##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -515,7 +515,7 @@ def normalize_fields(pcoll, fields, drop=(), append=False,
language='generic'):
if append:
return input_schema, {
- **{name: name
+ **{name: f'`{name}`' if language == 'sql' else name
Review Comment:
looks like these issues should be easily caught with some tests. So can we
add more tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
